-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image integration refactor and cleanup #4482
Conversation
🦋 Changeset detectedLatest commit: 11f16fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Flipping this back to draft to test out a few more potential optimizations |
279be90
to
c1ba2e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, you're gonna make lots of people happy, @tony-sull 🥳
Left some suggestions for your consideration! Including a reminder that you can set a file name for a code sample and get a fancy Hippo title tab for your snippet.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
/public
can now be used like remote images 🎉glob
that the SSR build was doingTesting
Tests updated to match the new logic, mainly related to output filenames including Vite hashes
Docs
README updated with a few details on using
/public
images