Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@astrojs/image] Build all optimized images to dist/assets #4678

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

tony-sull
Copy link
Contributor

@tony-sull tony-sull commented Sep 8, 2022

Changes

Closes #4677

Fixes a bug that that was building optimized images in the main dist directory during SSG builds. These should be put in dist/assets along side other static assets built by Vite

Testing

Tests updated to expect the dist/assets directory

Docs

None, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

🦋 Changeset detected

Latest commit: c8c0bfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tony-sull tony-sull changed the title fix: build all optimized images to dist/assets [@astrojs/image] Build all optimized images to dist/assets Sep 8, 2022
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 8, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there any sense in introducing an option to customize this as long as we're looking at this logic?

packages/integrations/image/src/build/ssg.ts Show resolved Hide resolved
@tony-sull tony-sull merged commit 4c05c65 into main Sep 8, 2022
@tony-sull tony-sull deleted the fix/image-outdir branch September 8, 2022 18:41
This was referenced Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/image] images should be built to dist/assets
2 participants