Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind v2 docs #4758

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Tailwind v2 docs #4758

merged 3 commits into from
Sep 14, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 14, 2022

Changes

  • Add migration section to Tailwind v2 changelog
  • Update README to include tailwindcss in manual install instructions
  • Is there anywhere else we can/should document the migration steps?

Testing

Docs only

Docs

cc @withastro/maintainers-docs for feedback!

@delucis delucis requested a review from a team as a code owner September 14, 2022 20:30
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: 87364a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/tailwind Patch
@e2e/e2e-tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 14, 2022
@@ -0,0 +1,5 @@
---
"@astrojs/tailwind": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do a release from this? People will just read this from the github anyways, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also updates the README which we usually trigger a patch for but I can remove if you think it's unnecessary.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs updates approved, @delucis! Thanks for this!

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@delucis
Copy link
Member Author

delucis commented Sep 14, 2022

Thanks all! I've also manually updated the GitHub release notes to match: https://github.com/withastro/astro/releases/tag/%40astrojs%2Ftailwind%402.0.0

@delucis delucis merged commit 0398efa into main Sep 14, 2022
@delucis delucis deleted the chris/tailwind-v2 branch September 14, 2022 20:43
@astrobot-houston astrobot-houston mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants