Support strict dependency install for image integration #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d14b55c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bluwy
commented
Oct 10, 2022
Comment on lines
-52
to
-54
| optimizeDeps: { | ||
| include: ['image-size'].filter(Boolean), | ||
| }, |
There was a problem hiding this comment.
It doesn't look like image-size is being accessed in the client through some testing, and Vite/Astro was reporting that it can't resolve image-size with pnpm, so I removed this.
matthewp
approved these changes
Oct 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4995
ssr.externalso they are not transformed by Vite when callingssrLoadModuleto load the renderer.kleuras dependency as it's used inssg.tsNote: Vite's SSR externalization doesn't take into account of loading modules from
node_moduleshence we got this issue and have to usessr.externalmanually. This could be fixed in Vite, but I feel like we should use normalimport()to load renderers instead (that would be a breaking change)Testing
This one's hard to test due to our monorepo structure, however I tested the repro in #4995 which works with this PR.
Existing tests should ideally pass too.
Docs
N/A. should work by default.