Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update with-tailwind example to use mdx #5104

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

JLarky
Copy link
Contributor

@JLarky JLarky commented Oct 16, 2022

Changes

  • added mdx integration to with-tailwind example
  • fixed component import from an old format to new MDX style
  • ran formatting since it's different for .md and .mdx
  • I can't run changeset for example folders
  • I see that some examples use "workspace:*" as dependency version, I personally think this is an anti-pattern because it makes it harder to use examples with degit or something like that
before after
image image

Testing

I opened with-tailwind example at astro.new and saw that it wasn't working. You can test the new version in my fork

Docs

This just fixes a bug, no updates needed

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2022

⚠️ No Changeset found

Latest commit: 9bd05f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Oct 16, 2022
@matthewp
Copy link
Contributor

Wow, can't believe we had the old components in markdown implementation still in there. Thanks!

@matthewp matthewp merged commit 66e8ae3 into withastro:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants