Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw when using Response.redirect from SSG site #5116

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2022

🦋 Changeset detected

Latest commit: c74ba83

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 18, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, always frustrating when dev and build don't match!

@matthewp matthewp merged commit 500acb3 into main Oct 18, 2022
@matthewp matthewp deleted the response-redirect-warn branch October 18, 2022 20:09
@astrobot-houston astrobot-houston mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response.redirect from an SSG Page should error
2 participants