Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs.promises.rm to remove node deprecation warning #5119

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 19, 2022

Changes

fs.promises.rmdir is deprecated. I got this warning when building:

(node:45043) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

https://nodejs.org/api/deprecations.html#DEP0147

Use fs.promises.rm(path, { recursive: true, force: true }) instead.

Testing

Existing test should pass.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

🦋 Changeset detected

Latest commit: 91255a8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 19, 2022
@matthewp matthewp merged commit 430e034 into main Oct 19, 2022
@matthewp matthewp deleted the chore-fs-rm branch October 19, 2022 14:03
@astrobot-houston astrobot-houston mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants