Throw error when trying to use the vercel static adapter in server mode #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e0b73f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
JuanM04
approved these changes
Oct 28, 2022
Merged
1 task
PixsaOJ
reviewed
Feb 9, 2023
| @@ -22,6 +22,10 @@ export default function vercelStatic(): AstroIntegration { | |||
| 'astro:config:done': ({ setAdapter, config }) => { | |||
| setAdapter(getAdapter()); | |||
| _config = config; | |||
|
|
|||
| if(config.output === 'server') { | |||
| throw new Error(`${PACKAGE_NAME} should be used with output: 'static'`); | |||
There was a problem hiding this comment.
Can you explain this? Does this mean there is Vercel adapter needed for static build?
I am experimenting with Vercel without adapters and Im having trouble with "command astro not found issue" which is in my dependencies.
Is this adapter meant to fix issues like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Tested in example project
Docs
N/A, bug fix