fix(rss): add missing type-attribute for xsl stylesheets #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e7dd2c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fflaten
changed the title
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the
type="text/xsl"attribute to xml-stylesheet processing instruction in rss. It was removed by mistake in #5550.The type attribute will only be added when the stylesheet ends with
.xslto enable support for css-stylesheet as well.Fix #5581
Testing
Updated the tests using
chai-xmlto verify both using a xsl stylesheet (include attribute) and a css stylesheet (no type-attribute).Docs
Not sure if necessary. This is a bugfix for xsl-stylesheets, but technically allows use of css-stylesheets. Not sure if it should be recommended by including in docs.
/cc @withastro/maintainers-docs for feedback!