Drop Node 14 support #5782
Merged
Drop Node 14 support #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5322217 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
natemoo-re
reviewed
Jan 6, 2023
Princesseuh
commented
Jan 9, 2023
Princesseuh
commented
Jan 9, 2023
| @@ -7,6 +7,7 @@ import { | |||
| import { Event, EventTarget } from 'event-target-shim' | |||
| import { Blob, File } from 'fetch-blob/from.js' | |||
| import { FormData } from 'formdata-polyfill/esm.min.js' | |||
| import * as undici from 'undici' | |||
There was a problem hiding this comment.
Trying to import the needed classes directly from undici failed with a weird error, probably because it's CJS. I couldn't figure it out, but this works
matthewp
reviewed
Jan 9, 2023
| const reader = stream.getReader(); | ||
|
|
||
| try { | ||
| while (true) { |
There was a problem hiding this comment.
any code with a while(true) gets my approval
There was a problem hiding this comment.
And a try / finally? This code has it all!
matthewp
approved these changes
Jan 9, 2023
Princesseuh
commented
Jan 9, 2023
natemoo-re
approved these changes
Jan 9, 2023
| @@ -198,7 +198,6 @@ | |||
| "eol": "^0.9.1", | |||
| "memfs": "^3.4.7", | |||
| "mocha": "^9.2.2", | |||
| "node-fetch": "^3.2.5", | |||
| const reader = stream.getReader(); | ||
|
|
||
| try { | ||
| while (true) { |
There was a problem hiding this comment.
And a try / finally? This code has it all!
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now that Node 14 is going EOL, we can remove some old stuff we had to support it. I, for one, welcome our new Node 16, 18 and 20 overlords.
Testing
Docs
We'll make a PR to docs indicating that we now have 16 as a minimum version