Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trailingSlash with base breaking partytown file path #5936

Merged
merged 6 commits into from
Jan 23, 2023
Merged

fix: trailingSlash with base breaking partytown file path #5936

merged 6 commits into from
Jan 23, 2023

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Jan 22, 2023

Fixes #5935

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2023

🦋 Changeset detected

Latest commit: e516bb5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jan 22, 2023
@matthewp matthewp merged commit 77ae7a5 into withastro:main Jan 23, 2023
matthewp pushed a commit that referenced this pull request Jan 26, 2023
* fix: trailingSlash with base breaking partytown file path

* Update index.ts

* Update index.ts

* Update index.ts

* fix lint

* Update index.ts
@rishi-raj-jain rishi-raj-jain deleted the fix-5935 branch September 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"base" option in combination with "trailingSlash: 'never'" leads to wrong URI for partytown
2 participants