Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoprefixer on dev mode for tailwind plugin #6002

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

royeden
Copy link
Contributor

@royeden royeden commented Jan 27, 2023

A recent PR (#5717) seems to have removed the autoprefixer postcss plugin for the TailwindCSS integration when it's not running in build mode. This breaks styles in development mode (#5989) because vendor prefixes aren't applied when it's running.

Changes

  • Removed isBuild check before running the autoprefixer plugin. It will run in every build mode.
  • Added appearance-none class to examples to test the components.

Testing

  • Added appearance-none tests, as this is a vendor prefixed css value (this is tested with the -webkit prefix as playwright runs on chrome).

Docs

This change wouldn't affect the current docs.

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023

🦋 Changeset detected

Latest commit: 4ebac6d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Jan 27, 2023
@bluwy bluwy linked an issue Jan 27, 2023 that may be closed by this pull request
1 task
@bluwy bluwy requested a review from a team as a code owner January 27, 2023 14:13
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have discussed and decided to re-enable autoprefixer for now.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment below!

packages/integrations/tailwind/README.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@bluwy bluwy merged commit 254eb21 into withastro:main Jan 27, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jan 27, 2023
@royeden royeden deleted the fix-tailwind-dev-autoprefixer branch January 27, 2023 15:29
@astrobot-houston astrobot-houston mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astro/tailwind is not adding prefixes in devmode
3 participants