-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autoprefixer on dev mode for tailwind plugin #6002
Conversation
…tup) that removed autoprefixer in non build modes
🦋 Changeset detectedLatest commit: 4ebac6d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have discussed and decided to re-enable autoprefixer for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment below!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
A recent PR (#5717) seems to have removed the autoprefixer postcss plugin for the TailwindCSS integration when it's not running in build mode. This breaks styles in development mode (#5989) because vendor prefixes aren't applied when it's running.
Changes
isBuild
check before running the autoprefixer plugin. It will run in every build mode.appearance-none
class to examples to test the components.Testing
appearance-none
tests, as this is a vendor prefixed css value (this is tested with the -webkit prefix as playwright runs on chrome).Docs
This change wouldn't affect the current docs.