Support tsconfig aliases in styles #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f62d7bd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Mar 16, 2023
Merged
1 task
bholmesdev
added a commit
that referenced
this pull request
Mar 23, 2023
This reverts commit ea9b3dd.
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6551
Support tsconfig aliases in styles, like
@import. This only supportscompilerOptions.pathsaliases for styles, but notbaseUrlaliases since it's not possible to use Vite aliases without accidentally overriding Vite's internal aliases.This could be a fine compromise for now as
compilerOptions.pathsaliases are more commonly used.Testing
Added test for
baseUrlalias and CSS@import.Docs
n/a. bug fix. Maybe in the future we could document the
baseUrlcaveat if it turns out to be commonly used and confusing for users.