Resolve images in the frontmatter relative to the current file #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b2af55 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
I see this is all WIP, but love this implementation! Pretty simple all things considered 👍 |
natemoo-re
approved these changes
Mar 23, 2023
| object[schemaName] = z.preprocess( | ||
| async (value: unknown) => { | ||
| if (!value || typeof value !== 'string') return value; | ||
| return (await resolver(value))?.id; |
There was a problem hiding this comment.
Do we have a test for aliased paths?
There was a problem hiding this comment.
We do! This file has it all: a relative path, a nested path and an aliased path.
matthewp
approved these changes
Mar 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously, all images in the frontmatter were relative to
src/assets, this PR changes it so it's relative to the current file instead. This is a proper resolve, so you can use aliases (including~/assets/) and stuff.This PR does not cover using images in certain cases, such as arrays. This is intentional as this is not supported at the moment in general so I'll tacle it in a dedicated PR
Testing
Updated tests
Docs
withastro/docs#2910