Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using optimized images with base #6643

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Fix using optimized images with base #6643

merged 8 commits into from
Mar 27, 2023

Conversation

Princesseuh
Copy link
Member

Changes

I did not understand how base work, which honestly, is not that surprising considering how confused a lot of us are about it 😔

Fix #6504

Testing

Added a bunch of tests

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: 1201ef4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 24, 2023
@Princesseuh Princesseuh changed the title Fix/images base Fix using optimized images with base Mar 24, 2023
@Princesseuh Princesseuh requested a review from matthewp March 24, 2023 16:19
@Princesseuh Princesseuh merged commit fc0ed9c into main Mar 27, 2023
@Princesseuh Princesseuh deleted the fix/images-base branch March 27, 2023 13:50
@astrobot-houston astrobot-houston mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image assets paths not correctly resolved if using URL base in site config
4 participants