HTML minification

[JerryWu1234]

Changes

• Implementation for HTML Minification roadmap#537
• Adds the compressHTML flag to the config, defaulting to false.
• This value is passed to the compiler's compact flag.

Testing

• Test case added for dev and build which verifies the HTML is compressed by checking the number of lines in the output (should be 1).

Docs

• Config value is documented in the types.

[changeset-bot]

🦋 Changeset detected

Latest commit: 756b68e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[JerryWu1234]

@matthewp cc

[sarah11918]

Thanks for this, @wulinsheng123! One little paragraph raised a couple of questions below. 😅

I'm going to take this opportunity to converge on some standardizing of how we define these Booleans, so thanks for being my guinea pig and putting a little extra work in here! I've offered a couple of suggestions for wording that match the structure of other terms on this page, and want to double check what the default value actually is (true or false) in order to make the example as helpful and realistic as possible.

I leave it in y'all's hands to come up with something reasonable based on my feedback! 🙌

[matthewp]

@wulinsheng123 can you add a test for dev? I know you said it wasn't working there. Then @bluwy or myself will test out what the problem is.

[JerryWu1234]

@wulinsheng123 can you add a test for dev? I know you said it wasn't working there. Then @bluwy or myself will test out what the problem is.

Please tell me a clue on how to test for dev. because I have tried a lot, there is no better idea. But I'm definitely sure I have passed that property to the compiler.

[matthewp]

@wulinsheng123 The fixture object has a way to create a dev server. Then you can make requests against it, similar to how you do in the build. Here's an example test file that tests both build and dev:

astro/packages/astro/test/astro-get-static-paths.test.js

Line 45 in 14fd198

devServer = await fixture.startDevServer();

[matthewp]

I submitted the stage 3 RFC here: withastro/roadmap#581

[ematipico]

I believe we should add a test for SSR too, what do you think?

[ematipico]

Nice work! 🚀

[bluwy]

Implementation looks great! Have one small nit below.

[matthewp]

Blocking to prevent accidental merge before release day.

Merge day!