Fix check CLI fs load fallback behaviour #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2cc09bc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
approved these changes
Apr 10, 2023
matthewp
approved these changes
Apr 10, 2023
|
Yeah sync is passed with fs so it can be unit-tested to swap out the fs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6629
In
vite-plugin-load-fallback, thefscheck wasn't right when thefsis fromimport * as fs from 'fs'. This PR fixes it.I also simplified the
resolveIdhook as thethis.resolveand alwaysslashifypart doesn't seem necessary. Other plugins should've already resolve before theload-fallbackplugin, and alwaysslashifymakes it impossible for a plugin to runthis.resolveto check if an id is resolveable (e.g.tsconfig-aliaspluginbaseUrl)Testing
Existing tests should pass. The edgecase in #6629 is a little hard to test, but once I do some tsconfig aliases soon, the regression shouldn't happen again.
Docs
n/a. bug fix.