-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't exit the program if dependencies don't install #7052
Conversation
🦋 Changeset detectedLatest commit: 561cace The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hmm, I'm not sure I agree with this change. I think the warning is too subtle for users (we have to think that it's new users using create astro) and will result in many people asking for help on Discord due to thinking the deps installed when they didn't. In my opinion, increasing the timeout so it happens less often (if that is in fact the issue) would be a better first step |
It could be a timeout issue, but it could also be another issue that we can't control. Even if we change the timeout, we are back to square one. We can change the messaging, surely. I think we should not exit the program. |
I think I'd at least go with an error instead of a warning maybe? |
b702cb5
to
e16791e
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you have a screenshot of the output after the changes?
@delucis here's the updated (simulated) error |
Unfortunately, with the current APIs of What do you guys think? |
Oh right… that’s unfortunate. I guess this PR is still much better than the whole thing crashing, but it would definitely be nice to avoid the confusing “Dependencies failed to install… Dependencies installed” message. How tricky is it to update this in a followup PR to |
@delucis We can definitely do a follow up PR with the change! |
Changes
Closes #6600
This change affects only the "dependencies" phase, but in my opinion, we should do this for each step.
Testing
I manually changed the code to throw an error
Docs
N/A
cc @withastro/maintainers-docs for feedback! Quick review of the new message