Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sitemap filter #7263

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Fix sitemap filter #7263

merged 2 commits into from
Jun 2, 2023

Conversation

andremralves
Copy link
Contributor

Fixes #7256

  • Change the position of pageUrls value attribution.

Testing

  • Added two test cases using filter, one for Static and the other for SSR pages.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: 7d52ae4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 1, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bluwy bluwy merged commit dff0d0d into withastro:main Jun 2, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 2, 2023
dguo added a commit to dguo/dannyguo.com that referenced this pull request Jul 16, 2023
Draft posts show up in the sitemap with higher versions.

There was a fix for filtering in general:
withastro/astro#7263

But it didn't seem to fix drafts. There is a broader discussion for how
to handle drafts:
withastro/astro#7324
dguo added a commit to dguo/dannyguo.com that referenced this pull request Jul 16, 2023
Draft posts show up in the sitemap with higher versions.

There was a fix for filtering in general:
withastro/astro#7263

But it didn't seem to fix drafts. There is a broader discussion for how
to handle drafts:
withastro/astro#7324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sitemap filter does not actually filter pages
2 participants