Make APIRoute generic like APIContext #7521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3db6cb4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
reviewed
Jun 30, 2023
This reverts commit c71c4e6.
|
Looks like CI is passing now and the breaking change should be handled. |
ematipico
approved these changes
Jul 2, 2023
bluwy
approved these changes
Jul 3, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
APIContextis generic so thatpropscan be typed, butAPIRoute, which composesAPIContext, is not likewise generic. This PR changes that.Testing
No tests, just a backwards-compatible change to a type.
Docs
No docs added, it was intuitive to me to expect
APIRouteto be generic and I was rather surprised that it wasn't already.