Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/markdoc assets #7706

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix/markdoc assets #7706

merged 2 commits into from
Jul 18, 2023

Conversation

Princesseuh
Copy link
Member

Changes

A previous PR removed emitESMImage from astro/assets/index.js to fix Vercel Edge support, however, the Markdoc integration imported that. We didn't catch it for two reasons:

  • Due to moduleResolution: 'node' not being able to get the types properly, there's a @ts-expect-error there, so type checking didn't fail
  • For CI performance reason, we don't run the CI of every single integration on all core changes, so the tests fails weren't caught

Fix #7705

Testing

Tests should pass!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

🦋 Changeset detected

Latest commit: 22fb13d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Jul 18, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a slight breaking change for markdoc still, since it now requires the latest Astro version to work, but I think it's better that reverting the other fix that causes another regression.

@Princesseuh
Copy link
Member Author

It might be a slight breaking change for markdoc still, since it now requires the latest Astro version to work, but I think it's better that reverting the other fix that causes another regression.

Surface area is small, it's only broken in specifically 2.8.4, so users can choose to stay on 2.8.3 or update the Markdoc integration. It's a tiny bit annoying, but it's not too bad

@Princesseuh Princesseuh merged commit 4f6b5ae into main Jul 18, 2023
12 of 13 checks passed
@Princesseuh Princesseuh deleted the fix/markdoc-assets branch July 18, 2023 16:03
@astrobot-houston astrobot-houston mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astrojs/markdoc integration fails import
3 participants