Fix rendering TextEncoder encoding error regression #7777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab47ce9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
I personally experienced the error both with Wrangler and in CF production. I will later try and see if I can isolate it into small example. |
Princesseuh
approved these changes
Jul 24, 2023
|
@reneklacan that would be much appreciated! I'll merge this for now so we can get a release out to fix the regression. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #7775
My bad. My PR (#7730) accidentally reverted the fix from #6070. I tried making a test, but I can't reproduce it. Might be a difference between wrangler and cloudflare prod?
Testing
Not sure how to test this. I can't reproduce it with wrangler.
Docs
n/a. bug fix.