refactor: use pipeline in Development mode #8115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ematipico
commented
Aug 17, 2023
Comment on lines
+65
to
+70
| async loadRenderers() { | ||
| const renderers = await Promise.all( | ||
| this.#settings.renderers.map((r) => loadRenderer(r, this.#loader)) | ||
| ); | ||
| this.env.renderers = renderers.filter(Boolean) as SSRLoadedRenderer[]; | ||
| } |
There was a problem hiding this comment.
As you can notice, the side effects stay inside the pipeline, so we can better control them.
bluwy
approved these changes
Aug 17, 2023
Thank you! I had imagined :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR takes the pipeline concept into development mode.
The
DevPipelineis very similar to theBuildPipeline. Like in the previous PR, thepipelineobject is passed around, and functions request from it all the information that is needed.This refactor removes the need for
DevelopmentEnviroment:AstroSettingsandModuleLoaderare stored in theDevPipeline, and functions use its gettersgetSettingsandgetModuleLoader.I also removed
tryRenderRoute, which was deprecated.Testing
I updated some unit tests to use this new
DevPipeline. Eventually, we should use a newTestPipelinefor these kinds of tests, but not in this PR.Docs
N/A