Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove turbolinks integration #8186

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Remove turbolinks integration #8186

merged 1 commit into from
Aug 22, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 22, 2023

Changes

  • Remove turbolinks integration as it has been long deprecated (We had also remove the webapi package and image integration from the monorepo for 3.0)
  • Made an unrelated change to remove packages/astro/src/vite-plugin-mdx/import-source.ts as the file is unused (I was checking for unused code in the repo)

Testing

Existing tests should pass.

Docs

n/a

@bluwy bluwy requested a review from a team as a code owner August 22, 2023 08:34
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

⚠️ No Changeset found

Latest commit: 02463e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 22, 2023
Princesseuh
Princesseuh approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of PR.

@bluwy bluwy merged commit b8ad9a2 into next Aug 22, 2023
@bluwy bluwy deleted the remove-turbolinks-integration branch August 22, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluwy @matthewp @ematipico @Princesseuh