View Transition: swap attributes of document's root element #8206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 82bb974 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
@matthewp would like to ask you for review. |
matthewp
reviewed
Aug 24, 2023
| // - reinsert all original attributes that are named 'data-astro-*' | ||
| const html = document.documentElement; | ||
| const astro = [...html.attributes].filter( | ||
| ({ name }) => (html.removeAttribute(name), name.startsWith('data-astro-')) |
|
This does fix a bug, although I don't think we have an issue for it. It was reported on discord IIRC, that the |
matthewp
approved these changes
Aug 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix: extends swap() to include the attributes of the documents root element
Testing
added e2e test
Docs
n/a
bug fix