Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vercel serverless adapter logs too much #8581

Merged
merged 9 commits into from
Sep 18, 2023
Merged

fix: Vercel serverless adapter logs too much #8581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
49dc0ab
log only once in serverless adapter
Sep 16, 2023
1c872db
Update fluffy-dodos-rule.md
Sep 18, 2023
f8b8198
Merge branch 'main' into fix-runtime-message
Sep 18, 2023
b590d66
validateRuntime
Sep 18, 2023
ef866cc
Merge branch 'main' into fix-runtime-message
Sep 18, 2023
9368735
vRun
Sep 18, 2023
3f5d90f
Merge branch 'main' into fix-runtime-message
Sep 18, 2023
f33f153
return 'nodejs18.x';
Sep 18, 2023
2320da7
return;
Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-dodos-rule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/vercel': patch
---

log only once in serverless adapter
15 changes: 13 additions & 2 deletions packages/integrations/vercel/src/serverless/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ You can set functionPerRoute: false to prevent surpassing the limit.`
const filesToInclude = includeFiles?.map((file) => new URL(file, _config.root)) || [];
filesToInclude.push(...extraFilesToInclude);

validateRuntime();

// Multiple entrypoint support
if (_entryPoints.size) {
const getRouteFuncName = (route: RouteData) => route.component.replace('src/pages/', '');
Expand Down Expand Up @@ -312,7 +314,7 @@ You can set functionPerRoute: false to prevent surpassing the limit.`
};
}

function getRuntime() {
function validateRuntime() {
const version = process.version.slice(1); // 'v16.5.0' --> '16.5.0'
const major = version.split('.')[0]; // '16.5.0' --> '16'
const support = SUPPORTED_NODE_VERSIONS[major];
Expand All @@ -322,7 +324,7 @@ function getRuntime() {
);
console.warn(`[${PACKAGE_NAME}] Your project will use Node.js 18 as the runtime instead.`);
console.warn(`[${PACKAGE_NAME}] Consider switching your local version to 18.`);
return 'nodejs18.x';
rishi-raj-jain marked this conversation as resolved.
Show resolved Hide resolved
return;
}
if (support.status === 'deprecated') {
console.warn(
Expand All @@ -336,5 +338,14 @@ function getRuntime() {
);
console.warn(`[${PACKAGE_NAME}] Consider upgrading your local version to 18.`);
}
}

function getRuntime() {
const version = process.version.slice(1); // 'v16.5.0' --> '16.5.0'
const major = version.split('.')[0]; // '16.5.0' --> '16'
const support = SUPPORTED_NODE_VERSIONS[major];
if (support === undefined) {
return 'nodejs18.x';
}
return `nodejs${major}.x`;
}
Loading