Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vercel): maxDuration config #8867

Merged
merged 10 commits into from
Oct 23, 2023
Merged

feat(vercel): maxDuration config #8867

merged 10 commits into from
Oct 23, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 18, 2023 •
edited
Loading

Changes

image

Testing

Added a fixture and test that .vc-config.json has the expected field.

Docs

Added a section to the README.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7085f7f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Oct 18, 2023
lilnasy
lilnasy commented Oct 18, 2023
View reviewed changes
packages/integrations/vercel/src/serverless/adapter.ts
runtime: getRuntime(),
handler,
launcherType: 'Nodejs',
maxDuration,
Copy link
Contributor Author

@lilnasy lilnasy Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new part. Commenting for quick visibility.

Relevant Vercel docs: https://vercel.com/docs/build-output-api/v3/primitives#base-config.

@lilnasy lilnasy marked this pull request as ready for review October 19, 2023 22:32
@ematipico
Copy link
Member

It would be great if we can find out what's the maximum allowed, so we can throw an error early.

Vercel documentation doesn't mention it, I see what I can do.

@lilnasy
Copy link
Contributor Author

lilnasy commented Oct 20, 2023 •
edited
Loading

Yes, it is 900s for enterprise customers. Although, I'm not sure if custom contracts can allow longer.

https://vercel.com/docs/functions/serverless-functions/runtimes#maxduration

@lilnasy lilnasy force-pushed the feat/vercel-max-duration branch from 06daf3c to 0eb004e Compare October 20, 2023 14:24
sarah11918
sarah11918 reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a couple of suggestions! 🙌

packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
@lilnasy @sarah11918
Apply suggestions from code review
630279c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@ematipico ematipico merged commit b209e53 into withastro:main Oct 23, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 23, 2023
Merged
@lilnasy lilnasy deleted the feat/vercel-max-duration branch October 30, 2023 15:03
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
@lilnasy @sarah11918 @natemoo-re
feat(vercel): maxDuration config (#8867)
b6a609f 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@bluwy bluwy bluwy approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vercel Serverless Function Timeout
4 participants
@lilnasy @ematipico @sarah11918 @bluwy