Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining simple objects usage #9266

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 1, 2023

Changes

Make sure we don't return simple objects from endpoint anywhere else. Also made sure they're uppercase now.

I like Response.json

Testing

Existing tests should pass.

Docs

n/a. internal change to tests and examples.

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 8f65d57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels Dec 1, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…/pages/welcome-data.json.js

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@bluwy bluwy merged commit ac41820 into main Dec 1, 2023
14 checks passed
@bluwy bluwy deleted the remove-remaining-simple-objects branch December 1, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants