Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: markdown-remark peerDependencies #9349

Merged
merged 1 commit into from
Dec 7, 2023
Merged

chore: markdown-remark peerDependencies #9349

merged 1 commit into from
Dec 7, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 6, 2023

Changes

  • Removes peerDependencies from @astrojs/markdown-remark

Testing

Does not affect behavior

Docs

Does not affect usage

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 23b12d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pr: docs A PR that includes documentation for review labels Dec 6, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approved? Peer dependencies scare me!

Comment on lines -30 to -32
"peerDependencies": {
"astro": "^4.0.0-beta.0"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think this is alright? Definitely don't think there's any Astro 4.0.0 specific things happening.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some other packages that have "astro": "^4.0.0-beta.0" too strangely. Not that we should remove them, but I think they should be ^4.0.0 instead 🤔

@bluwy bluwy merged commit 270c6cc into main Dec 7, 2023
13 checks passed
@bluwy bluwy deleted the markdown-remark-peer branch December 7, 2023 15:04
@astrobot-houston astrobot-houston mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants