Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vercel): Add beta option for status #9413

Merged
merged 12 commits into from
Dec 13, 2023
Merged

chore(vercel): Add beta option for status #9413

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a462366
Add beta option for status
Dec 12, 2023
2be4655
Create stupid-cheetahs-sell.md
Dec 12, 2023
cce926a
Merge branch 'main' into chore/update-supported-node-versions
Dec 12, 2023
bfd0770
Add warning for beta
Dec 12, 2023
3e5dd9f
Merge branch 'chore/update-supported-node-versions' of https://github…
Dec 12, 2023
943b5cf
Update packages/integrations/vercel/src/serverless/adapter.ts
Dec 12, 2023
fd96f1f
Switch to `minor` and document new API/option
Dec 12, 2023
d659d7d
Update README.md
Dec 12, 2023
f1649b2
Merge branch 'main' into chore/update-supported-node-versions
Dec 12, 2023
f948305
Update README.md
Dec 12, 2023
8da6099
Update packages/integrations/vercel/README.md
Dec 13, 2023
b2f12b6
Update .changeset/stupid-cheetahs-sell.md
Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-cheetahs-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/vercel': patch
jacobdalamb marked this conversation as resolved.
Show resolved Hide resolved
---

Update supported Node versions and add `beta` option.
florian-lefebvre marked this conversation as resolved.
Show resolved Hide resolved
jacobdalamb marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 9 additions & 2 deletions packages/integrations/vercel/src/serverless/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ export const VERCEL_EDGE_MIDDLEWARE_FILE = 'vercel-edge-middleware';
// https://vercel.com/docs/concepts/functions/serverless-functions/runtimes/node-js#node.js-version
const SUPPORTED_NODE_VERSIONS: Record<
string,
{ status: 'current' } | { status: 'deprecated'; removal: Date }
{ status: 'current' } | { status: 'beta' } | { status: 'deprecated'; removal: Date }
> = {
14: { status: 'deprecated', removal: new Date('August 15 2023') },
16: { status: 'deprecated', removal: new Date('February 6 2024') },
18: { status: 'current' },
20: { status: 'beta' },
};

function getAdapter({
Expand Down Expand Up @@ -377,6 +377,13 @@ function validateRuntime() {
const version = process.version.slice(1); // 'v16.5.0' --> '16.5.0'
const major = version.split('.')[0]; // '16.5.0' --> '16'
const support = SUPPORTED_NODE_VERSIONS[major];
if (support.status === 'beta') {
console.warn(
`[${PACKAGE_NAME}] The local Node.js version (${major}) is currently in beta by Vercel Serverless Functions.`
jacobdalamb marked this conversation as resolved.
Show resolved Hide resolved
);
console.warn(`[${PACKAGE_NAME}] Make sure to update your Vercel settings to use ${major}.`);
return;
}
if (support === undefined) {
console.warn(
`[${PACKAGE_NAME}] The local Node.js version (${major}) is not supported by Vercel Serverless Functions.`
Expand Down
Loading