Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid vite 5.1 warning #9719

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Avoid vite 5.1 warning #9719

merged 1 commit into from
Jan 18, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 18, 2024

Changes

Vite 5.1 deprecates the optimizeDeps.disabled experimental option. It will emit this warning:

(!) Experimental optimizeDeps.disabled and deps pre-bundling during build were removed in Vite 5.1.
    To disable the deps optimizer, set optimizeDeps.noDiscovery to true and optimizeDeps.include as undefined or empty. 
    Please remove optimizeDeps.disabled from your config.

This PR updates to its suggested configuration.

Testing

Existing tests should pass

Docs

n/a. internal refactor.

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 3a4bec2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 18, 2024
@bluwy bluwy merged commit 7e1db8b into main Jan 18, 2024
13 checks passed
@bluwy bluwy deleted the vite-5.1-warning branch January 18, 2024 08:38
@astrobot-houston astrobot-houston mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants