-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(@astrojs/node): use Node.js for testing #9758
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its-happening.gif
Would love to see if there's any differences in speed! |
This PR
|
I am closing this for now because the regressions are concerning. Node.js runs tests in parallel, spawning a process for each test. While this decision is understandable, there should be a way to allow to run tests in one single process. I opened a feature request here: nodejs/node#51548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after fixing the conflicts and the small nit below.
* Run tests in a single process * Make test less flaky
4008e33
to
7e0544b
Compare
7e0544b
to
bf5669a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply
Changes
This PR moves
@astrojs/node
to use Node.js for testingTesting
Tests should pass
Docs
N/A