fix(NodeApp): fix responses with null bodies never completing

[lilnasy]

Changes

• Fixes Node.js SSR redirect timeout #9925

Testing

• Added a test case for redirects, thanks @friedemannsommer.
• Adjusted a test introduced in fix(NodeApp): end with "Internal server error" on mid-stream error #9908 to address flakiness.
• Cherry-picked chore(tests): restore correct assertions #9930 to unbreak remaining tests.

Docs

Does not affect usage.

[changeset-bot]

🦋 Changeset detected

Latest commit: 61a606c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[friedemannsommer]

@lilnasy I've come up with a different test implementation should i discard my changes or do you want to integrate them with your's?

see: friedemannsommer@68c6784

[lilnasy]

Do you mean for the tests?

[friedemannsommer]

Do you mean for the tests?

@lilnasy Yes correct, I mean the test implementation.

[lilnasy]

The test looks great to me, I want to add that. Although adding a new fixture also means adding its build-time to the CI. If you could make it use an existing fixture, I will add it.

[friedemannsommer]

The test looks great to me, I want to add that. Although adding a new fixture also means adding its build-time to the CI. If you could make it use an existing fixture, I will add it.

@lilnasy The only other fixture with the "SSR" prefix that has "@astrojs/node" in it's dependencies is "ssr-api-route". Should I migrate the tests into this fixture then?

[lilnasy]

Could you use the one used in the current test?

[friedemannsommer]

Could you use the one used in the current test?

@lilnasy Sure i'll use your implementation as a base then, give me ~5 minutes.

[friedemannsommer]

@lilnasy It took me a bit more than 5 minutes, sorry for that. (I am not familiar with the Node.js test runner)
I've added the examples i used to your changes here: friedemannsommer@713d019 + friedemannsommer@bd19bdb

[lilnasy]

I need to adjust errors.test.js. I can cherry pick your commit afterwards, thanks!