Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-specificity Scoping #330

Merged
merged 20 commits into from
Jul 22, 2022
Merged

Zero-specificity Scoping #330

merged 20 commits into from
Jul 22, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 14, 2022

Changes

  • Implements RFC0012

  • Still uses our current .astro-XXXXXX classes, but changes generated styles to not change the specificity of your selector.

    • In practice, this means that what previously generated div.astro-XXXXXX will now generate div:where(.astro-XXXXXX) and preserve the authored specificity of the div selector.
  • Compat table for :where

CleanShot 2022-07-22 at 13 44 56@2x

Testing

Tests updated!

Docs

Need to mention in migration guide

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

🦋 Changeset detected

Latest commit: aed1ed5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re force-pushed the feat/zero-specificity branch 2 times, most recently from 7a87841 to 78d4732 Compare March 14, 2022 17:28
@natemoo-re natemoo-re force-pushed the feat/zero-specificity branch from 78d4732 to 92002c0 Compare April 2, 2022 01:15
@natemoo-re natemoo-re added this to the 1.0.0-rc milestone May 16, 2022
@natemoo-re natemoo-re force-pushed the feat/zero-specificity branch from 4603704 to e2ecd85 Compare May 16, 2022 18:12
@natemoo-re natemoo-re self-assigned this May 18, 2022
@natemoo-re natemoo-re added - P3: minor bug An edge case that only affects very specific usage (priority) breaking labels May 20, 2022
@natemoo-re natemoo-re mentioned this pull request Jul 21, 2022
20 tasks
@natemoo-re natemoo-re force-pushed the feat/zero-specificity branch from ab0832b to de81350 Compare July 21, 2022 18:56
@natemoo-re natemoo-re marked this pull request as ready for review July 21, 2022 18:56
@natemoo-re natemoo-re force-pushed the feat/zero-specificity branch from bd14a79 to 5cd0ff7 Compare July 21, 2022 19:20
@natemoo-re natemoo-re removed the - P3: minor bug An edge case that only affects very specific usage (priority) label Jul 22, 2022
@natemoo-re natemoo-re merged commit c19cd8c into main Jul 22, 2022
@natemoo-re natemoo-re deleted the feat/zero-specificity branch July 22, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants