Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix serialize spread attribute #414

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

ota-meshi
Copy link
Contributor

Changes

This PR fixes the wrong serialize when it has a spread attribute in utils's serialize method.
This fix is related to withastro/prettier-plugin-astro#193.

Testing

I have added the spread attribute to the serialize test case template.

Docs

bug fix only.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022

🦋 Changeset detected

Latest commit: d3c236c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natemoo-re natemoo-re merged commit 5221e09 into withastro:main May 31, 2022
@ota-meshi ota-meshi deleted the print branch May 31, 2022 23:08
natemoo-re pushed a commit that referenced this pull request Jul 20, 2022
* fix: fix serialize spread attribute

* Create tame-eyes-provide.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants