Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add section about remote images to assets #4246

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Aug 17, 2023

What kind of changes does this PR include?

  • New or updated content

Description

withastro/astro#7778 adds support for remote images, this PR updates the mention of remote images to specify that they'll be processed and document the two new options that decide which images are allowed to be processed

Sarah's 3.0 assets guide rewrite this part completely, so this is only temporary content until 3.0 releases

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 7c55b5d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64df8b9c4417a80008cb0096
😎 Deploy Preview https://deploy-preview-4246--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for merge-on-release. After the ci docs, the config reference links should be fine.

src/content/docs/en/guides/assets.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Aug 17, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit 586d5ad into main Aug 18, 2023
@yanthomasdev yanthomasdev deleted the feat/remote-optimization branch August 18, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants