Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new routing priority behavior #6386

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Jan 14, 2024

Description

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 11:04am

Copy link
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Fryuni! Thank you for documenting all of these rules!

I have left some typo fixes and suggestions for the routing.mdx file, but not the reference files because I believe those are auto-generated from the JSDocs.

Hope they help!

src/content/docs/en/core-concepts/routing.mdx Outdated Show resolved Hide resolved
src/content/docs/en/core-concepts/routing.mdx Outdated Show resolved Hide resolved
src/content/docs/en/core-concepts/routing.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 15, 2024
@sarah11918 sarah11918 added this to the 4.2.0 milestone Jan 15, 2024
@sarah11918
Copy link
Member

sarah11918 commented Jan 15, 2024

I am noting that this feature will be released as an experimental flag for 4.2.0, which means that the ONLY documentation should be in the changeset and @types/astro.ts file under "experimental flags" for configuration reference.

This PR should not be merged as there will be no wider docs changes (as there never are for experimental flag features changing behaviour. All documentation is contained to the experimental config section). BUT, we can use this to help craft that!

We will use withastro/astro#9644 as a model/reference for how to document for an experimental flag that builds on/changes existing features.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not to be merged, used in helping us prepare documentation in withastro/astro#9439 only.

@sarah11918 sarah11918 marked this pull request as ready for review January 16, 2024 18:57
@sarah11918 sarah11918 dismissed their stale review January 16, 2024 18:59

docs now for the patch only!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last piece of the puzzle! Approved!

@Fryuni
Copy link
Member Author

Fryuni commented Jan 16, 2024

Lovely, thanks for sending the changes @sarah11918. You're the best!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 17, 2024
@sarah11918 sarah11918 merged commit c5c074b into withastro:main Jan 18, 2024
7 of 8 checks passed
yanthomasdev added a commit that referenced this pull request Jan 25, 2024
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: voxel!() <voxelmc@hotmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
fhiromasa added a commit to fhiromasa/astro-docs that referenced this pull request Mar 3, 2024
Document new routing priority behavior (withastro#6386)
yanthomasdev added a commit that referenced this pull request Mar 5, 2024
* Update routing.mdx in ja

Modified to be similar to the English sample code in "Nested Pagination" section

* update routing.mdx in ja

[code-example-syntax] hippo-proof code examples (#5364)

* update routing.mdx in ja

fix: add spacing to 'added in' texts (#5765)

* update routing.mdx in ja

Add <ReadMore> component (#6267)

* Update routing.mdx in ja

Document new routing priority behavior (#6386)

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

---------

Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants