Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic routes example in isr.exclude for @astrojs/vercel integration #7651

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add dynamic routes example in isr.exclude for @astrojs/vercel integration #7651

merged 2 commits into from
Mar 28, 2024

Conversation

tk04
Copy link
Contributor

@tk04 tk04 commented Mar 28, 2024

Description (required)

Added an example that shows how you would exclude dynamic routes from ISR.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.x. See astro PR #10513.

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 28, 2024 2:36pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 requested a review from lilnasy March 28, 2024 14:10
@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Mar 28, 2024
lilnasy
lilnasy approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me content-wise. Just a small suggestion regarding communication.

src/content/docs/en/guides/integrations-guide/vercel.mdx Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Thank you for this contribution @tk04 ! I am going to ask @lilnasy to review this one when he's available!

@tk04 @lilnasy
Update src/content/docs/en/guides/integrations-guide/vercel.mdx
db25844 
Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 28, 2024
@lilnasy lilnasy merged commit 8c0a62a into withastro:main Mar 28, 2024
6 of 7 checks passed
@huyikai huyikai mentioned this pull request Mar 28, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilnasy lilnasy lilnasy approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tk04 @astrobot-houston @sarah11918 @lilnasy