Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ja): Add new reference/api-reference.mdx translation #8888

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

i18n(ja): Add new reference/api-reference.mdx translation #8888

wants to merge 18 commits into from

Conversation

n-tong009
Copy link
Contributor

Description

Add a new Japanese translation to src/content/docs/ja/reference/api-reference.mdx

The original English version: src/content/docs/en/reference/api-reference.mdx

n-tong009 and others added 15 commits July 1, 2024 17:16
@n-tong009
Create sharing-state-islands.mdx
e1d8bbf 
i18n(ja): Add new sharing-state-islands.mdx translation
@n-tong009
i18n(ja): update recipes/sharing-state-islands.mdx
8185401
@delucis
Merge branch 'main' into patch-1
ec0519f
@n-tong009 @satoru2727
Apply suggestions from code review
7707c8f 
Co-authored-by: Satoru <92915718+satoru2727@users.noreply.github.com>
@n-tong009
Merge branch 'main' into patch-1
b2e64fc
@n-tong009
i18n(ja): update recipes/sharing-state-islands.mdx
6b1050e 
アンカーリンクの遷移が動作するように調整しました。
@yanthomasdev
Merge branch 'main' into patch-1
8358eba
@yanthomasdev @satoru2727
Fix link
d4b91cd 
Co-authored-by: Satoru <92915718+satoru2727@users.noreply.github.com>
@yanthomasdev
Merge branch 'main' into patch-1
1ec0408
@n-tong009
i18n(ja): Update nav.ts translation
2629670 
The latest translations have been added to reflect the updated contents of the [/src/i18n/en/nav.ts] file.
@n-tong009
Merge branch 'withastro:main' into main
93e235b
@n-tong009
Merge branch 'withastro:main' into main
8c93e49
@n-tong009
i18n(ja): Add new reference/api-reference.mdx translation
d55ca46
@n-tong009
i18n(ja): Update reference/api-reference.mdx translation
e8f3221
@n-tong009
Merge branch 'withastro:main' into patch-2
e859fb1
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 21, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cdbe39b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66a220cd2dc67900089a0dd2
😎 Deploy Preview https://deploy-preview-8888--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 21, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja reference/api-reference.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

SnowDingo
SnowDingo reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@SnowDingo SnowDingo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳への貢献、ありがとうございます！
まだレビューは完全に終わっていないので承認などは難しいですが、とりあえず読んだところで気になった所は変更点を挙げておきました。
👍

@n-tong009 n-tong009 marked this pull request as draft July 22, 2024 02:00
@n-tong009 n-tong009 marked this pull request as ready for review July 22, 2024 02:04
@SnowDingo
Copy link
Contributor

レビュー終わらせておきました！
文字数が多いのに、ここまで完璧に訳してくれてありがとうございます。僕が気になった点は小さなリンク（ウィキペディアやMozilla Docs）の変更と、ローケルをローカルに直したぐらいです。
一応、いくつかのページで今回の翻訳でリンクが壊れてしまうページがあるので、そちらを直せば完了だと思います。
翻訳ありがとうございました🚀

@n-tong009
Copy link
Contributor Author

@SnowDingo
チェックありがとうございます！
レビューが飛んできていないみたいなので、再度確認していただければです！🙇

SnowDingo
SnowDingo suggested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@SnowDingo SnowDingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー承認お願いします🙏

src/content/docs/ja/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Show resolved Hide resolved
src/content/docs/ja/reference/api-reference.mdx Show resolved Hide resolved
@n-tong009 @SnowDingo
i18n(ja): Update reference/api-reference.mdx translation
73e4495 
The link information has been adjusted.

Co-authored-by: Fire Dingo <101443426+SnowDingo@users.noreply.github.com>
@n-tong009
Copy link
Contributor Author

@SnowDingo
ローカルだと locale と local の言葉が被ってしまうのと、別ページ でロケールをすでに使用されているので、今回はロケールにしようかと思います！
ご意見ありがとうございました！

@n-tong009 @SnowDingo
i18n(ja): Update reference/api-reference.mdx translation
cdbe39b 
The link information has been adjusted.

Co-authored-by: Fire Dingo <101443426+SnowDingo@users.noreply.github.com>
@SnowDingo
Copy link
Contributor

@SnowDingo ローカルだと locale と local の言葉が被ってしまうのと、別ページ でロケールをすでに使用されているので、今回はロケールにしようかと思います！ ご意見ありがとうございました！

了解です👍
こちら側の知識不足だったので次からレビューするときは気を付けます！

yanthomasdev
yanthomasdev reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work peeps, could I ask you to make a commit fixing any broken links and updating this to the latest changes? See: https://github.com/withastro/docs/commits/main/src/content/docs/en/reference/api-reference.mdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@SnowDingo SnowDingo SnowDingo requested changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n-tong009 @astrobot-houston @SnowDingo @yanthomasdev @delucis