Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new variant to command #9110

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: add new variant to command #9110

merged 5 commits into from
Aug 28, 2024

Conversation

ematipico
Copy link
Member

Description (required)

This PR adds a new variant to one of the options returned to the hook astro:config:setup

For Astro version: 4.15. See astro PR #11729.

@ematipico ematipico mentioned this pull request Aug 15, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 43a82e1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ccb9ed0056040008018504
😎 Deploy Preview https://deploy-preview-9110--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 15, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/integrations-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added this to the 4.15 milestone Aug 16, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Aug 16, 2024
@sarah11918
Copy link
Member

@ematipico Looks like this will need updating in the section below, around lines 106-112 too?

@Fryuni Fryuni changed the title feat: add new variant do command feat: add new variant to command Aug 22, 2024
@ematipico
Copy link
Member Author

Updated!

@sarah11918
Copy link
Member

@ematipico Thank you, but it also needs a line at 113 explaining it! 😄 Is it just the same text as the explanations for the others, or is it different?

@ematipico
Copy link
Member Author

@sarah11918 done

yanthomasdev
yanthomasdev approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sarah11918
sarah11918 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Another one ready to go for 4.15! Thank you @ematipico !

@sarah11918 sarah11918 changed the base branch from main to 4.15.0 August 26, 2024 22:02
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 26, 2024
@sarah11918
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>

@sarah11918 sarah11918 merged commit 04cf2c1 into 4.15.0 Aug 28, 2024
1 check passed
@sarah11918 sarah11918 deleted the feat/new-variant branch August 28, 2024 20:38
@sarah11918 sarah11918 mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.15
Development

Successfully merging this pull request may close these issues.
4 participants
@ematipico @astrobot-houston @sarah11918 @yanthomasdev