Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docgen): Automatically add deprecated messages to removed errors #9157

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

Princesseuh
Copy link
Member

Description (required)

Astro developers keep not following my carefully crafted rules regarding removing errors. Which probably mean my rules are not so carefully crafted. This PR makes it so when an error is removed, a basic deprecated message is added automatically, so at least there's some indication that one could upgrade their Astro version to proceed further.

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit c2d50f7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66d06adb8936910008885e48
😎 Deploy Preview https://deploy-preview-9157--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/errors/env-invalid-variable.mdx Source changed, localizations will be marked as outdated.
en reference/errors/invalid-rewrite404.mdx Source changed, localizations will be marked as outdated.
en reference/errors/locals-not-serializable.mdx Source changed, localizations will be marked as outdated.
en reference/errors/markdown-content-schema-validation-error.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 Thanks @Princesseuh!

scripts/error-docgen.mjs Outdated Show resolved Hide resolved
Princesseuh and others added 3 commits August 28, 2024 15:23
@delucis delucis added improve documentation Enhance existing documentation (e.g. add an example, improve description) ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Aug 29, 2024
@delucis delucis merged commit 9cb0b62 into main Aug 29, 2024
10 checks passed
@delucis delucis deleted the feat/deprecate-errors branch August 29, 2024 12:44
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 30, 2024
yanthomasdev added a commit that referenced this pull request Aug 30, 2024
* i18n(fr): update Actions errors

See #9236

* i18n(fr): add deprecated notice to some errors

See #9157

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants