Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change comment starter in strapi.mdx #9197

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

ChinoUkaegbu
Copy link
Contributor

Description (required)

The comment in the env file for the strapi integration started with // instead of # and this change replaced it.

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f04b00
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66cb40052a8b9f000880118b
😎 Deploy Preview https://deploy-preview-9197--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/cms/strapi.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking charge on this one

@at-the-vr at-the-vr merged commit 46e7c87 into withastro:main Aug 25, 2024
11 checks passed
@ChinoUkaegbu ChinoUkaegbu deleted the docs/fix-typo-in-env branch August 25, 2024 15:27
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 25, 2024
yanthomasdev added a commit that referenced this pull request Aug 25, 2024
See #9197

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Issue: Use correct comment style in .env file for Astro / Strapi integration page
3 participants