feat(next): better tsconfig docs #9218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Looks good! Just a couple of little comments! Thanks @florian-lefebvre !
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
added
add new content
|
@florian-lefebvre I don't think this was released in alpha.3, so I'll let you decide whether you want to wait to merge this for whichever release it goes out in, or just do it now. FYI, on the breaking change guides, I have been updating to show the alpha release number so that if people are looking at the upgrade guide, they can see which ones have or haven't been actually released yet and are just placeholders. So that way it's fine if this merges early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Updates our tsconfig recommendations
Related issues & labels (optional)
For Astro version:
5.0. See astro PR #11859.