-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: GetCompletions
broken for Vim with YouCompleteMe plugin
#948
Comments
I'm the maintainer of the ycmd client. The extra escaping happens when writing to my client's logs.
While the extra escaping does not look odd to me, the following does:
EDIT: the 2nd and 3rd point are about refresh requests. Yes, those are not supported. Still, the snippets look out of place. |
Apologies, not sure I understand everything. Is it just the language server sending snippet completions even when unsupported by the client? |
Yes, I believe you've got it!... Sorry for the superfluous stuff and mistakes related to double-quote escaping 🤦 After cloning the :vimgrep /\csnippet/ src/**/*.ts
... But none of the bits found seem to have easy access to client defined capabilities;
If ya got a moment, I'd much appreciate being directed at the correct points of interest and would be delighted to test possible fixes too! |
This is an issue on the Volar side, it has been fixed in volarjs/volar.js@2787b79 and will be released in 2.4.3. |
Ah, thanks for showing me where in the code this feature detection was needed! ... Wow, looks like that commit is fresh too, like less than a half-hour, impressive @johnsoncodehk very impressive ✨ |
Howdy again! I spotted the fix got published for Break down of what I've tested so far
... So I currently believe this bug to be successfully squished 🎉 Thanks @johnsoncodehk and @Princesseuh for the help and quick fix! |
Apologies for the late response. |
Describe the Bug
Looks like preexisting escapes for double-quotes are getting an extra back-slash for example within
.result.items[1]
;.additionalTextEdits[0].newText
.data.original.additionalTextEdits[0].newText
... This bad backslash behavior may be breaking third-party plugins too, such as Emmet!
GetCompletions_maybe-bad.json
GetCompletions_maybe-good.json
Steps to Reproduce
npm init astro
using template<NAME>
npm i -g @astrojs/language-server
~/.vimrc
pushd /home/USER/git/hub/PROJECT/NAME
vim
Content of
.ycm_extra_conf.py
Content of
tsconfig.json
Content of
example.astro
Client and Server logs
ycm_stderr.log
ycm_stdout.log
Link to Minimal Reproducible Example
ycm-core/lsp-examples#43
The text was updated successfully, but these errors were encountered: