Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sync version of the compiler #349

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented May 31, 2023

Changes

Blocked by withastro/compiler#800

Use the compiler's sync entrypoint. Removing the need for synckit completely, making the Prettier plugin faster and lighter!

Testing

Tests should still pass!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: 3e26bba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh Princesseuh marked this pull request as ready for review May 31, 2023 17:10
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this hack removed! Thanks for leading the charge on this!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset

@Princesseuh Princesseuh merged commit af9324e into main Jun 1, 2023
@Princesseuh Princesseuh deleted the feat/sync-compiler branch June 1, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants