Format markdown component content #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
antonyfaris
force-pushed
the
fix/markdown-content
branch
from
255c8f2 to
dcf79e6
Compare
jasikpark
approved these changes
Nov 24, 2021
| if (isDocCommand(formattedStyles)) return formattedStyles; | ||
| formattedStyles = formattedStyles[0]; | ||
|
|
||
| formattedStyles = stripTrailingHardline(formattedStyles); |
There was a problem hiding this comment.
Oh! I appreciate the function instead of the other logic
|
Thanks for your patience with my review of it - sorry for letting it sit for a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the format of markdown inside a markdown component.
Fixes #41
Fixes #42
Testing
I added an extra test.
Docs