Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-CN): Update getting-started.mdx #1165

Merged
merged 2 commits into from
Nov 29, 2023
Merged

i18n(zh-CN): Update getting-started.mdx #1165

merged 2 commits into from
Nov 29, 2023

Conversation

leovoon
Copy link
Contributor

@leovoon leovoon commented Nov 29, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7855d96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 29, 2023 2:10pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 29, 2023
delucis
delucis reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation @leovoon! Left a couple of comments for things we could improve.

docs/src/content/docs/zh-cn/getting-started.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/zh-cn/getting-started.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/zh-cn/getting-started.mdx Outdated Show resolved Hide resolved
delucis
delucis approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those fixes! 🚀

@delucis delucis merged commit 64d25c1 into withastro:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovoon @delucis