Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Pinterest icon to social list #2135

Merged

Conversation

oluwatobiss
Copy link
Contributor

@oluwatobiss oluwatobiss commented Jul 22, 2024

This PR adds a Pinterest icon to the social links list.

Here's a screenshot showing a usage example on a Starlight website's header:

Pinterest icon in Starlight site header

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: d050b42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit d050b42
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/669fb391216c890008d6d31b
😎 Deploy Preview https://deploy-preview-2135--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oluwatobiss! This looks great. Left a couple of tiny comments, but this is basically perfect 🙌

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
.changeset/soft-bananas-develop.md Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Jul 22, 2024
oluwatobiss and others added 2 commits July 22, 2024 15:11
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@oluwatobiss oluwatobiss requested a review from delucis July 22, 2024 14:24
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @oluwatobiss!

@delucis delucis merged commit 9bbb969 into withastro:main Jul 23, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 23, 2024
@oluwatobiss oluwatobiss deleted the feat/add-pinterest-icon-to-social-list branch July 23, 2024 15:32
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 6, 2024
* main: (275 commits)
  [ci] release (withastro#2165)
  Define well-known RTL locales before calling `getLocaleInfo()` for default locale (withastro#2167)
  Update dependencies (withastro#2166)
  Improve page load performance (withastro#2155)
  docs: Add CodeSweetly to showcase (withastro#2160)
  [ci] release (withastro#2145)
  Fix bug for projects with spaces in their pathname (withastro#2156)
  ci: update file icons (withastro#2157)
  [ci] format
  Merge <link rel="canonical" /> tags, quick fixes (withastro#2153) (withastro#2154)
  Add two new showcase sites (withastro#2149)
  [ci] format
  i18n(zh-cn): Update `environmental-impact.md` (withastro#2148)
  add Saasfly showcase (withastro#2147)
  docs: add 'og:image:alt' metadata (withastro#2143)
  Deleting unnecessary twitter meta tags, quick fixes (withastro#2137)
  [ci] format
  i18n(es): update `environmental-impact` (withastro#2144)
  [ci] release (withastro#2142)
  feat: Add Pinterest icon to social list (withastro#2135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants