-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Carbon Calculator data in environmental impact guide #2136
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A nice visual addition to give some context to the numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
| [GitBook][gb-carbon] | 0.43g | C | | ||
| [Mintlify][mt-carbon] | 1.22g | F | | ||
|
||
<small>Data collected on 22 July 2024. Click a link to see up-to-date figures.</small> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<small>Data collected on 22 July 2024. Click a link to see up-to-date figures.</small> | |
<small>Data collected on 22 July 2024. Click a respective framework's link to see up-to-date figures.</small> |
Makes it a little more clear which link is being referred to. But may already be clear enough in this context, up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I suspect it's clear enough already. Although now you have me second guessing whether "click" is the right action at all if someone is on a touch device etc. 😅
Going to merge without this so I don't need to get into that, but thanks nonetheless!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update, love the new rating 🌟
Description
This PR updates the data in the comparison table in our environmental impact guide.
Preview: https://deploy-preview-2136--astro-starlight.netlify.app/environmental-impact/#comparisons