Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Carbon Calculator data in environmental impact guide #2136

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Jul 22, 2024

Description

This PR updates the data in the comparison table in our environmental impact guide.

  • Updates CO₂ numbers (last update was back in May 2023)
  • Adds a “Rating” column to show letter grades from Website Carbon Calculator’s new rating system
  • Adds Mintlify to the table

Preview: https://deploy-preview-2136--astro-starlight.netlify.app/environmental-impact/#comparisons

This comment was marked as off-topic.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 2f89e04
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/669e4f8340970c0008170540
😎 Deploy Preview https://deploy-preview-2136--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en environmental-impact.md Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 5.96 KB (0%)
/_astro/*.js 21.87 KB (0%)
/_astro/*.css 13.79 KB (0%)

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A nice visual addition to give some context to the numbers.

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

| [GitBook][gb-carbon] | 0.43g | C |
| [Mintlify][mt-carbon] | 1.22g | F |

<small>Data collected on 22 July 2024. Click a link to see up-to-date figures.</small>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<small>Data collected on 22 July 2024. Click a link to see up-to-date figures.</small>
<small>Data collected on 22 July 2024. Click a respective framework's link to see up-to-date figures.</small>

Makes it a little more clear which link is being referred to. But may already be clear enough in this context, up to you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suspect it's clear enough already. Although now you have me second guessing whether "click" is the right action at all if someone is on a touch device etc. 😅

Going to merge without this so I don't need to get into that, but thanks nonetheless!

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, love the new rating 🌟

@delucis delucis merged commit c71b0a2 into main Jul 22, 2024
16 checks passed
@delucis delucis deleted the chris/carbon-update branch July 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants