-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flickr to social icons #2584
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small details missed, but this a great start! Here’s another recent social icon PR which is a good reference: #2579
We’ll also need to:
- Update the error message expected in
packages/starlight/__tests__/basics/config-errors.test.ts
- Add a changeset
Ah and we’ll need to double check the icon itself is working. Right now looks like this for me:
Looks like the path you added is much larger than the 32x32 size we expect.
Also taking a look at these icons and wondering if they’ll really be understood as indicating Flickr?
We haven’t done this often but for the pkl
icon we use opacity
to create a lower contrast on the central part of the icon and maybe should do the same here for one of the circles 🤔 (Probably strictly speaking you’re not supposed to use the dots with a monochrome style at all though, they only show the wordmark in black in the Flickr brand guidelines.)
Yeah, admittedly it's not an ideal logo they've chosen. In other situations, I've used a generic camera icon personally. And, if we shouldn't use monochrome anyway, then I'm happy to just close this, as the coloured versions wouldn't make sense. It's not my fault they've chosen poorly with their branding 😅 |
Alright, happy to close the two dots branding and shame Flickr about their branding! Just thought it was worth a try! |
Description
This PR adds a new social icon option
flickr
and a corresponding svg path for the Flickr logo.I don't know how to test this, or if I've missed anything, but this maybe comes close? 😄