Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flickr to social icons #2584

Closed
wants to merge 1 commit into from
Closed

add flickr to social icons #2584

wants to merge 1 commit into from

Conversation

sarah11918
Copy link
Member

Description

This PR adds a new social icon option flickr and a corresponding svg path for the Flickr logo.

I don't know how to test this, or if I've missed anything, but this maybe comes close? 😄

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 9c84124

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 9c84124
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/672ceaea4f32120008b8bf12
😎 Deploy Preview https://deploy-preview-2584--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.15 KB (+0.04% 🔺)
/_astro/*.js 22.37 KB (-0.05% 🔽)
/_astro/*.css 13.73 KB (0%)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small details missed, but this a great start! Here’s another recent social icon PR which is a good reference: #2579

We’ll also need to:

  • Update the error message expected in packages/starlight/__tests__/basics/config-errors.test.ts
  • Add a changeset

Ah and we’ll need to double check the icon itself is working. Right now looks like this for me:

missing flickr icon

Looks like the path you added is much larger than the 32x32 size we expect.


Also taking a look at these icons and wondering if they’ll really be understood as indicating Flickr?

a grid of different flickr icons most of which are just two dots of the same grey side by side

We haven’t done this often but for the pkl icon we use opacity to create a lower contrast on the central part of the icon and maybe should do the same here for one of the circles 🤔 (Probably strictly speaking you’re not supposed to use the dots with a monochrome style at all though, they only show the wordmark in black in the Flickr brand guidelines.)

@sarah11918
Copy link
Member Author

Yeah, admittedly it's not an ideal logo they've chosen. In other situations, I've used a generic camera icon personally. And, if we shouldn't use monochrome anyway, then I'm happy to just close this, as the coloured versions wouldn't make sense. It's not my fault they've chosen poorly with their branding 😅

@sarah11918
Copy link
Member Author

Alright, happy to close the two dots branding and shame Flickr about their branding! Just thought it was worth a try!

@sarah11918 sarah11918 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants